Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2731203002:
Fix QuicSpdyStreamTest. (Closed)
|
Created:
3 years, 9 months ago by Ryan Hamilton Modified:
3 years, 9 months ago CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix QuicSpdyStreamTest.
Review-Url: https://codereview.chromium.org/2731203002
Cr-Commit-Position: refs/heads/master@{#454925}
Committed: https://chromium.googlesource.com/chromium/src/+/e8cf2b3e52941a3d8cd632908dbd81a4a7b02470
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #
Dependent Patchsets: Messages
Total messages: 28 (18 generated)
rch@chromium.org changed reviewers: + ckrasic@chromium.org, ianswett@chromium.org
ckrasic: PTAL ianswett: FYI Set FLAGS_quic_reloadable_flag_quic_limit_uncompressed_headers = true Fix QuicSpdyStreamTest to pass. For some reason it look like changes from internal cl/136385860 were not completely merged. https://codereview.chromium.org/2462823002/diff/20001/net/quic/core/quic_spdy...
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by ianswett@chromium.org
lgtm lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by ckrasic@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for net/quic/core/quic_flags_list.h:
While running git apply --index -p1;
error: patch failed: net/quic/core/quic_flags_list.h:120
error: net/quic/core/quic_flags_list.h: patch does not apply
Patch: net/quic/core/quic_flags_list.h
Index: net/quic/core/quic_flags_list.h
diff --git a/net/quic/core/quic_flags_list.h b/net/quic/core/quic_flags_list.h
index
8d28400385cee4c2d4519df57f1b0795277b3835..2f7c76fd4162a7d83fed4e22d62a083a270e92d5
100644
--- a/net/quic/core/quic_flags_list.h
+++ b/net/quic/core/quic_flags_list.h
@@ -120,7 +120,7 @@ QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_remove_v33_hacks2, false)
// If true, limits QUIC uncompressed headers to 16K.
QUIC_FLAG(bool,
FLAGS_quic_reloadable_flag_quic_limit_uncompressed_headers,
- false)
+ true)
// If true, release headers stream\'s sequencer buffer when there is no active
// stream.
The CQ bit was checked by rch@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by rch@chromium.org
The CQ bit was checked by rch@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ianswett@chromium.org, ckrasic@chromium.org Link to the patchset: https://codereview.chromium.org/2731203002/#ps80001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488827663082540,
"parent_rev": "9d6d06986b7ad2e33f294710d170f78108060790", "commit_rev":
"292ccf6e9283c1bf0e38250d46c0c1c1e14eb828"}
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488827663082540,
"parent_rev": "c99c2556e9c996f68206c32ccc8281940169d49f", "commit_rev":
"e8cf2b3e52941a3d8cd632908dbd81a4a7b02470"}
Message was sent while issue was closed.
Description was changed from ========== Fix QuicSpdyStreamTest. ========== to ========== Fix QuicSpdyStreamTest. Review-Url: https://codereview.chromium.org/2731203002 Cr-Commit-Position: refs/heads/master@{#454925} Committed: https://chromium.googlesource.com/chromium/src/+/e8cf2b3e52941a3d8cd632908dbd... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/e8cf2b3e52941a3d8cd632908dbd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
