Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4326)

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.h

Issue 2731103002: cros: Remove CoreOobeHandler::Delegate. (Closed)
Patch Set: Initial upload Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.h
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h b/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
index 209ead66be3446ac21765acb1fa88578a3626db3..3c6e8288e14d08d7eb62e9988a13fdad82e0c162 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
@@ -67,7 +67,6 @@ class WrongHWIDScreenView;
// - eula screen (CrOS (+ OEM) EULA content/TPM password/crash reporting).
// - update screen.
class OobeUI : public content::WebUIController,
- public CoreOobeHandler::Delegate,
public ShutdownPolicyHandler::Delegate {
public:
// List of known types of OobeUI. Type added as path in chrome://oobe url, for
@@ -129,6 +128,9 @@ class OobeUI : public content::WebUIController,
// Initializes the handlers.
void InitializeHandlers();
+ // Called by CoreOobeHandler when the screen has changed.
achuithb 2017/03/08 11:32:52 Not sure we want to be specific about the caller.
jdufault 2017/03/09 19:24:14 Done.
+ void OnCurrentScreenChanged(OobeScreen screen);
+
// Invoked after the async assets load. The screen handler that has the same
// async assets load id will be initialized.
void OnScreenAssetsLoaded(const std::string& async_assets_load_id);
@@ -186,9 +188,6 @@ class OobeUI : public content::WebUIController,
void AddWebUIHandler(std::unique_ptr<BaseWebUIHandler> handler);
void AddScreenHandler(std::unique_ptr<BaseScreenHandler> handler);
- // CoreOobeHandler::Delegate implementation:
- void OnCurrentScreenChanged(OobeScreen screen) override;
-
// Type of UI.
std::string display_type_;

Powered by Google App Engine
This is Rietveld 408576698