Chromium Code Reviews| Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc |
| diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc |
| index e90286ac1d27ac15100b5bb92e48cbdd82d185c5..73643c3c32765d493e3c9787abc858dc2ef5229d 100644 |
| --- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc |
| +++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc |
| @@ -219,7 +219,6 @@ OobeUI::OobeUI(content::WebUI* web_ui, const GURL& url) |
| base::MakeUnique<CoreOobeHandler>(this, js_calls_container.get()); |
| core_handler_ = core_handler.get(); |
| AddWebUIHandler(std::move(core_handler)); |
| - core_handler_->SetDelegate(this); |
| auto network_dropdown_handler = base::MakeUnique<NetworkDropdownHandler>(); |
| network_dropdown_handler_ = network_dropdown_handler.get(); |
| @@ -328,7 +327,6 @@ OobeUI::OobeUI(content::WebUI* web_ui, const GURL& url) |
| } |
| OobeUI::~OobeUI() { |
| - core_handler_->SetDelegate(nullptr); |
| network_dropdown_handler_->RemoveObserver(GetView<ErrorScreenHandler>()); |
| if (ash_util::IsRunningInMash()) { |
| // TODO: Ash needs to expose screen dimming api. See |
| @@ -507,6 +505,31 @@ void OobeUI::InitializeHandlers() { |
| shutdown_policy_handler_->NotifyDelegateWithShutdownPolicy(); |
| } |
| +void OobeUI::OnCurrentScreenChanged(OobeScreen new_screen) { |
|
achuithb
2017/03/08 11:32:52
I assume nothing has changed in this implementatio
jdufault
2017/03/09 19:24:14
Yep, no changes.
|
| + previous_screen_ = current_screen_; |
| + |
| + const bool should_dim = |
| + std::find(std::begin(kDimOverlayScreenIds), |
| + std::end(kDimOverlayScreenIds), |
| + new_screen) != std::end(kDimOverlayScreenIds); |
| + if (!ash_util::IsRunningInMash()) { |
| + if (!screen_dimmer_) { |
| + screen_dimmer_ = base::MakeUnique<ash::ScreenDimmer>( |
| + ash::ScreenDimmer::Container::LOCK_SCREEN); |
| + } |
| + screen_dimmer_->set_at_bottom(true); |
| + screen_dimmer_->SetDimming(should_dim); |
| + } else { |
| + // TODO: Ash needs to expose screen dimming api. See |
| + // http://crbug.com/646034. |
| + NOTIMPLEMENTED(); |
| + } |
| + |
| + current_screen_ = new_screen; |
| + for (Observer& observer : observer_list_) |
| + observer.OnCurrentScreenChanged(current_screen_, new_screen); |
| +} |
| + |
| void OobeUI::OnScreenAssetsLoaded(const std::string& async_assets_load_id) { |
| DCHECK(!async_assets_load_id.empty()); |
| @@ -561,31 +584,6 @@ void OobeUI::RemoveObserver(Observer* observer) { |
| observer_list_.RemoveObserver(observer); |
| } |
| -void OobeUI::OnCurrentScreenChanged(OobeScreen new_screen) { |
| - previous_screen_ = current_screen_; |
| - |
| - const bool should_dim = |
| - std::find(std::begin(kDimOverlayScreenIds), |
| - std::end(kDimOverlayScreenIds), |
| - new_screen) != std::end(kDimOverlayScreenIds); |
| - if (!ash_util::IsRunningInMash()) { |
| - if (!screen_dimmer_) { |
| - screen_dimmer_ = base::MakeUnique<ash::ScreenDimmer>( |
| - ash::ScreenDimmer::Container::LOCK_SCREEN); |
| - } |
| - screen_dimmer_->set_at_bottom(true); |
| - screen_dimmer_->SetDimming(should_dim); |
| - } else { |
| - // TODO: Ash needs to expose screen dimming api. See |
| - // http://crbug.com/646034. |
| - NOTIMPLEMENTED(); |
| - } |
| - |
| - current_screen_ = new_screen; |
| - for (Observer& observer : observer_list_) |
| - observer.OnCurrentScreenChanged(current_screen_, new_screen); |
| -} |
| - |
| void OobeUI::UpdateLocalizedStringsIfNeeded() { |
| if (oobe_ui_md_mode_ == |
| g_browser_process->local_state()->GetBoolean(prefs::kOobeMdMode)) { |