Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Issue 273103003: Add responsiveness_metric for timeline_based_measurement (Closed)

Created:
6 years, 7 months ago by nednguyen
Modified:
6 years, 6 months ago
Reviewers:
tonyg, jjtswan, chrishenry, nduca
CC:
chromium-reviews, tfarina, telemetry+watch_chromium.org, ryoji_google.com, ruilopes
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add responsiveness_metric to timeline_based_measurement. responsiveness_metric is a timeline_based_metric. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275036

Patch Set 1 #

Total comments: 43

Patch Set 2 : Address Chris' comments #

Total comments: 2

Patch Set 3 : Rebase after partial lands #

Total comments: 8

Patch Set 4 : Address Chris's comments #

Total comments: 6

Patch Set 5 : Address Nat's comments #

Patch Set 6 : Rebase after partial lands. #

Total comments: 2

Patch Set 7 : Add TODO for fixing warning in repsonsiveness_metric #

Patch Set 8 : Disable timeline_based_measurement smoke test for responsive on windows platform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -8 lines) Patch
A tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats.py View 1 2 3 4 5 1 chunk +91 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_stats_unittest.py View 1 2 3 4 5 1 chunk +118 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py View 1 2 3 4 5 6 1 chunk +47 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 2 3 4 5 3 chunks +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 1 2 3 4 5 6 7 6 chunks +54 lines, -7 lines 0 comments Download
M tools/telemetry/unittest_data/interaction_enabled_page.html View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 30 (0 generated)
nednguyen
6 years, 7 months ago (2014-05-09 23:38:58 UTC) #1
chrishenry
I have a lot of questions, mostly since I'm still getting around to understand the ...
6 years, 7 months ago (2014-05-13 03:22:37 UTC) #2
nednguyen
https://codereview.chromium.org/273103003/diff/1/tools/telemetry/telemetry/core/timeline/event.py File tools/telemetry/telemetry/core/timeline/event.py (right): https://codereview.chromium.org/273103003/diff/1/tools/telemetry/telemetry/core/timeline/event.py#newcode6 tools/telemetry/telemetry/core/timeline/event.py:6: """Represents a timeline event. On 2014/05/13 03:22:38, chrishenry wrote: ...
6 years, 7 months ago (2014-05-14 17:32:27 UTC) #3
chrishenry
Nat or Tony, can you have a look at this too? I call out one ...
6 years, 7 months ago (2014-05-19 23:16:50 UTC) #4
nednguyen
On 2014/05/19 23:16:50, chrishenry wrote: > Nat or Tony, can you have a look at ...
6 years, 6 months ago (2014-05-29 17:18:39 UTC) #5
tonyg
Nat's definitely a better reviewer than me for this.
6 years, 6 months ago (2014-05-29 19:36:26 UTC) #6
chrishenry
lgtm This looks fine to me, but please wait for Nat's review. https://codereview.chromium.org/273103003/diff/40001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py File tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py ...
6 years, 6 months ago (2014-05-29 21:20:09 UTC) #7
nednguyen
https://codereview.chromium.org/273103003/diff/40001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py File tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py (right): https://codereview.chromium.org/273103003/diff/40001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py#newcode7 tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py:7: from telemetry.web_perf import timeline_interaction_record as tir_module On 2014/05/29 21:20:10, ...
6 years, 6 months ago (2014-05-29 22:13:45 UTC) #8
nduca
some feedback https://codereview.chromium.org/273103003/diff/60001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py File tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py (right): https://codereview.chromium.org/273103003/diff/60001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py#newcode70 tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py:70: if not _IsTopSlice(s): so we have "toplevel ...
6 years, 6 months ago (2014-05-29 23:33:11 UTC) #9
nednguyen
https://codereview.chromium.org/273103003/diff/60001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py File tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py (right): https://codereview.chromium.org/273103003/diff/60001/tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py#newcode70 tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py:70: if not _IsTopSlice(s): On 2014/05/29 23:33:12, nduca wrote: > ...
6 years, 6 months ago (2014-05-30 16:38:25 UTC) #10
nduca
Please pull off your edits to timeline and iter to a new patch so i ...
6 years, 6 months ago (2014-06-03 00:12:58 UTC) #11
nednguyen
On 2014/06/03 00:12:58, nduca wrote: > Please pull off your edits to timeline and iter ...
6 years, 6 months ago (2014-06-03 20:43:47 UTC) #12
nduca
lgtm https://codereview.chromium.org/273103003/diff/100001/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py File tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py (right): https://codereview.chromium.org/273103003/diff/100001/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py#newcode37 tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py:37: logging.warning( please turn this to TODO(nednguyen): Report a ...
6 years, 6 months ago (2014-06-04 18:51:22 UTC) #13
nednguyen
https://codereview.chromium.org/273103003/diff/100001/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py File tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py (right): https://codereview.chromium.org/273103003/diff/100001/tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py#newcode37 tools/telemetry/telemetry/web_perf/metrics/responsiveness_metric.py:37: logging.warning( On 2014/06/04 18:51:22, nduca wrote: > please turn ...
6 years, 6 months ago (2014-06-04 20:10:11 UTC) #14
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-04 20:10:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/273103003/120001
6 years, 6 months ago (2014-06-04 20:11:13 UTC) #16
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-04 21:41:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/273103003/140001
6 years, 6 months ago (2014-06-04 21:42:21 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 02:15:57 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 02:21:54 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10757)
6 years, 6 months ago (2014-06-05 02:21:55 UTC) #21
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-05 04:25:02 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/273103003/140001
6 years, 6 months ago (2014-06-05 04:25:51 UTC) #23
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 04:31:08 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 04:35:25 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10820)
6 years, 6 months ago (2014-06-05 04:35:25 UTC) #26
nednguyen
The CQ bit was checked by nednguyen@google.com
6 years, 6 months ago (2014-06-05 04:47:13 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nednguyen@google.com/273103003/140001
6 years, 6 months ago (2014-06-05 04:48:40 UTC) #28
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 04:54:03 UTC) #29
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 07:19:48 UTC) #30
Message was sent while issue was closed.
Change committed as 275036

Powered by Google App Engine
This is Rietveld 408576698