Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 273103003: Add responsiveness_metric for timeline_based_measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable timeline_based_measurement smoke test for responsive on windows platform Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
diff --git a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
index f8266390a3dd027f4717de183c557ebe176d228d..26800bad3719d9534313a4224a14adfb5d0d57a4 100644
--- a/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
+++ b/tools/telemetry/telemetry/web_perf/timeline_based_measurement.py
@@ -10,6 +10,7 @@ from telemetry.core.backends.chrome import tracing_backend
from telemetry.core.timeline import model as model_module
from telemetry.web_perf import timeline_interaction_record as tir_module
from telemetry.web_perf.metrics import smoothness
+from telemetry.web_perf.metrics import responsiveness_metric
from telemetry.page import page_measurement
from telemetry.value import string as string_value_module
@@ -58,7 +59,6 @@ class _TimelineBasedMetrics(object):
event in self._renderer_thread.async_slices
if tir_module.IsTimelineInteractionRecord(event.name)]
-
def AddResults(self, results):
interactions = self.FindTimelineInteractionRecords()
if len(interactions) == 0:
@@ -131,6 +131,8 @@ class TimelineBasedMeasurement(page_measurement.PageMeasurement):
res = []
if interaction.is_smooth:
res.append(smoothness.SmoothnessMetric())
+ if interaction.is_responsive:
+ res.append(responsiveness_metric.ResponsivenessMetric())
return res
def MeasurePage(self, page, tab, results):

Powered by Google App Engine
This is Rietveld 408576698