cc: Fix flaky LayerTreeHostScrollTestImplSideInvalidation

cc: Fix flaky LayerTreeHostScrollTestImplSideInvalidation

The test was making a wrong assumption that activation happens
synchronoulsy after impl-side invalidation. While we do synchronously
NotifyReadyToActivate, since there is no PrepareTiles, the activation
could be blocked on drawing the previous frame.

BUG=697652
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2731003003
Cr-Commit-Position: refs/heads/master@{#454981}
Committed: https://chromium.googlesource.com/chromium/src/+/7ee15a00fe953c13a83ef4faeddb9ec4a03dc1c1

[Khushal, 2017-03-04 03:16:55]

Description was changed from

==========
cc: Fix flaky LayerTreeHostScrollTestImplSideInvalidation

The test was making a wrong assumption that activation happens
synchronoulsy after impl-side invalidation. While we do synchronously
NotifyReadyToActivate, since there is no PrepareTiles, the activation
could be blocked on drawing the previous frame.

BUG=697652
==========

to

==========
cc: Fix flaky LayerTreeHostScrollTestImplSideInvalidation

The test was making a wrong assumption that activation happens
synchronoulsy after impl-side invalidation. While we do synchronously
NotifyReadyToActivate, since there is no PrepareTiles, the activation
could be blocked on drawing the previous frame.

BUG=697652
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2017-03-04 03:25:34]

khushalsagar@chromium.org changed reviewers:
+ danakj@chromium.org

[Khushal, 2017-03-04 03:25:40]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-04 03:25:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 04:13:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-04 04:13:27]

Dry run: This issue passed the CQ dry run.

[danakj, 2017-03-06 16:41:44]

LGTM

https://codereview.chromium.org/2731003003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/2731003003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_scroll.cc:2172: EXPECT_EQ(reason,
CommitEarlyOutReason::FINISHED_NO_UPDATES);
btw these EXPECT_EQ are all backward, it should be (expected, actual)

[Khushal, 2017-03-06 21:46:05]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-03-06 21:46:06]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/2731003003/#ps40001
(title: "..")

[Khushal, 2017-03-06 21:46:26]

https://codereview.chromium.org/2731003003/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest_scroll.cc (right):

https://codereview.chromium.org/2731003003/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest_scroll.cc:2172: EXPECT_EQ(reason,
CommitEarlyOutReason::FINISHED_NO_UPDATES);
On 2017/03/06 16:41:44, danakj wrote:
> btw these EXPECT_EQ are all backward, it should be (expected, actual)

Done.

[commit-bot: I haz the power, 2017-03-06 21:46:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 22:40:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488836765758130,
"parent_rev": "fd5e70a7895c65948d666dfad0e395e71b045459", "commit_rev":
"7ee15a00fe953c13a83ef4faeddb9ec4a03dc1c1"}

[commit-bot: I haz the power, 2017-03-06 22:41:35]

Description was changed from

==========
cc: Fix flaky LayerTreeHostScrollTestImplSideInvalidation

The test was making a wrong assumption that activation happens
synchronoulsy after impl-side invalidation. While we do synchronously
NotifyReadyToActivate, since there is no PrepareTiles, the activation
could be blocked on drawing the previous frame.

BUG=697652
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix flaky LayerTreeHostScrollTestImplSideInvalidation

The test was making a wrong assumption that activation happens
synchronoulsy after impl-side invalidation. While we do synchronously
NotifyReadyToActivate, since there is no PrepareTiles, the activation
could be blocked on drawing the previous frame.

BUG=697652
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2731003003
Cr-Commit-Position: refs/heads/master@{#454981}
Committed:
https://chromium.googlesource.com/chromium/src/+/7ee15a00fe953c13a83ef4faeddb...
==========

[commit-bot: I haz the power, 2017-03-06 22:41:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7ee15a00fe953c13a83ef4faeddb...