Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2730993003: MD Settings: People: Show correct user name (Closed)

Created:
3 years, 9 months ago by stevenjb
Modified:
3 years, 9 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: People: Show correct user name BUG=697388 Review-Url: https://codereview.chromium.org/2730993003 Cr-Commit-Position: refs/heads/master@{#454978} Committed: https://chromium.googlesource.com/chromium/src/+/3c427be05b644a371b692c1577061c7c09dbe23c

Patch Set 1 #

Patch Set 2 : Rebase + Fix test and elim misleading comments #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 1 1 chunk +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/settings/profile_info_handler_unittest.cc View 1 2 4 chunks +14 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
stevenjb
3 years, 9 months ago (2017-03-03 22:56:39 UTC) #2
tommycli
stevenjb: Thanks! LGTM
3 years, 9 months ago (2017-03-03 23:17:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730993003/1
3 years, 9 months ago (2017-03-03 23:24:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/377907)
3 years, 9 months ago (2017-03-03 23:59:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730993003/20001
3 years, 9 months ago (2017-03-06 20:16:47 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/403236)
3 years, 9 months ago (2017-03-06 20:35:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730993003/40001
3 years, 9 months ago (2017-03-06 20:44:40 UTC) #15
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 22:30:44 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/3c427be05b644a371b692c157706...

Powered by Google App Engine
This is Rietveld 408576698