Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2730923002: 📰 Only snap scroll when there is a fakebox (Closed)

Created:
3 years, 9 months ago by dgn
Modified:
3 years, 9 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Client] Only snap scroll when there is a fakebox Makes sure the RecyclerView does not calculate snap positions for the fakebox when it has been hidden after initialisation. BUG=698234 Review-Url: https://codereview.chromium.org/2730923002 Cr-Commit-Position: refs/heads/master@{#454592} Committed: https://chromium.googlesource.com/chromium/src/+/34094a69914e0cdc9a3215a0b53284d6f55c5b27

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dgn
PTAL
3 years, 9 months ago (2017-03-03 14:22:32 UTC) #4
Bernhard Bauer
LGTM, thanks!
3 years, 9 months ago (2017-03-03 14:23:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730923002/1
3 years, 9 months ago (2017-03-03 16:08:58 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 16:14:23 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/34094a69914e0cdc9a3215a0b532...

Powered by Google App Engine
This is Rietveld 408576698