Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2730903007: Implement lazy initialization for VrShellDelegate (Closed)

Created:
3 years, 9 months ago by mthiesse
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Implement lazy initialization for VrShellDelegate This allows VrShellDelegate to be created when it's needed, removing memory overhead for VR support when VR is not used. This CL also allows for VrShellDelegate to be destroyed once it's no longer needed as well, but that will be implemented in a follow up CL. Also also, this paves the way for allowing VrShellDelegate to attach to arbitrary ChromeActivities in the future (though for now only CTA is supported) Also also also, this fixes VrShellDelegate being accessible from CCT (and webview?) so that they now correctly return no displays available. BUG=655297, 689293 Review-Url: https://codereview.chromium.org/2727873002 Cr-Commit-Position: refs/heads/master@{#454474} (cherry picked from commit 182cf17def973f5d7a981025afb65ebd6f022ca9) Review-Url: https://codereview.chromium.org/2730903007 . Cr-Commit-Position: refs/branch-heads/3029@{#3} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/7cc487a97758ef4bdb217f80bf3eee82c13c9f6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -269 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 5 chunks +16 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java View 16 chunks +28 lines, -33 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapper.java View 3 chunks +17 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesWrapperImpl.java View 5 chunks +17 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 25 chunks +285 lines, -163 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 4 chunks +3 lines, -7 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java View 5 chunks +11 lines, -11 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 4 chunks +18 lines, -3 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_gl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java View 2 chunks +2 lines, -2 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M device/vr/android/gvr/gvr_delegate.cc View 1 chunk +7 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mthiesse
3 years, 9 months ago (2017-03-03 18:13:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7cc487a97758ef4bdb217f80bf3eee82c13c9f6d.

Powered by Google App Engine
This is Rietveld 408576698