Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1508)

Unified Diff: components/new_or_sad_tab_strings.grdp

Issue 2730903006: Add new sad tab strings. (Closed)
Patch Set: code review comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/new_or_sad_tab_strings.grdp
diff --git a/components/new_or_sad_tab_strings.grdp b/components/new_or_sad_tab_strings.grdp
index b140dcdb58affd3b26928aa232af6a1f722d52b8..ad9218a7a24ef1365c8628bfe7388ac306d88a75 100644
--- a/components/new_or_sad_tab_strings.grdp
+++ b/components/new_or_sad_tab_strings.grdp
@@ -36,6 +36,74 @@
Send Feedback
</message>
</if>
+ <if expr="is_win">
+ <message name="IDS_SAD_TAB_OOM_TITLE" desc="The title of the sad tab page displayed if the tab died due to being out of memory and a reload failed to fix the issue.">
srahim1 2017/03/03 19:42:08 desc="The title of the web page displayed if conte
Will Harris 2017/03/03 20:22:58 Done.
+ Not enough memory to open this page
+ </message>
+ </if>
+ <message name="IDS_SAD_TAB_RELOAD_TITLE" desc="The title of the sad tab page displayed if a reload failed to fix the issue.">
srahim1 2017/03/03 19:42:08 desc="The title of the web page displayed if conte
yyushkina 2017/03/03 20:03:26 Does this need formatter_data="android_java">
Will Harris 2017/03/03 20:22:57 Done.
Will Harris 2017/03/03 20:22:57 Done.
+ Can't open this page
+ </message>
+ <message name="IDS_SAD_TAB_OOM_MESSAGE_TABS" desc="The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and other tabs are open." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="The message displayed on the web page if con
Will Harris 2017/03/03 20:22:58 Done.
+ Try closing other tabs or programs to free up memory.
+ </message>
+ <message name="IDS_SAD_TAB_OOM_MESSAGE_NOTABS" desc="The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and no other tabs are open." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="The message displayed on the web page if con
Will Harris 2017/03/03 20:22:57 Done.
+ Try exiting other programs to free up memory.
+ </message>
+ <message name="IDS_SAD_TAB_RELOAD_TRY" desc="The first line of the message displayed on the sad tab page if a reload failed to fix the issue." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="The message displayed on the web page if con
+ Try the following tips:
+ </message>
+ <if expr="is_macosx"
+ <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done.
+ Open page in Incognito Mode (⇧⌘N)
srahim1 2017/03/03 19:42:07 Please change to "Incognito mode" with lowercase '
Will Harris 2017/03/03 20:22:57 Done.
+ </message>
+ </if>
+ <if expr="is_win or is_linux or chromeos"
+ <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done.
+ Open page in Incognito Mode (Ctrl-Shift-N)
srahim1 2017/03/03 19:42:07 "Incognito mode" with lowercase m
Will Harris 2017/03/03 20:22:56 Done.
+ </message>
+ </if>
+ <if expr="is_android or is_ios"
+ <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done.
+ Open page in Incognito Mode
srahim1 2017/03/03 19:42:08 "Incognito mode" with lowercase m
Will Harris 2017/03/03 20:22:57 Done.
+ </message>
+ </if>
+ <if expr="is_macosx or chromeos"
+ <message name="IDS_SAD_TAB_RELOAD_CLOSE_TABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are other open tabs, explaining to try closing tabs or other programs." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done.
+ Close other tabs or apps
+ </message>
+ </if>
+ <if expr="is_win or is_linux"
yyushkina 2017/03/03 20:03:27 Should be just is_linux
yyushkina 2017/03/03 20:22:29 Done.
Will Harris 2017/03/03 20:22:58 Done.
+ <message name="IDS_SAD_TAB_RELOAD_CLOSE_TABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are other open tabs, explaining to try closing tabs or other programs." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:58 Done.
+ Close other tabs or programs
+ </message>
+ </if>
+ <if expr="is_macosx or chromeos or is_android or is_ios"
+ <message name="IDS_SAD_TAB_RELOAD_CLOSE_NOTABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are no other open tabs, explaining to try closing other programs." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done.
+ Close other apps
+ </message>
+ </if>
+ <if expr="is_win or is_linux"
yyushkina 2017/03/03 20:03:27 Shouldn't this be only is_linux?
Will Harris 2017/03/03 20:05:29 I changed this to win since it seemed if we ever b
yyushkina 2017/03/03 20:22:29 Ok. That works
Will Harris 2017/03/03 20:22:57 Done.
+ <message name="IDS_SAD_TAB_RELOAD_CLOSE_NOTABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are no other open tabs, explaining to try closing other programs." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:56 Done.
+ Close other programs
+ </message>
+ </if>
+ <message name="IDS_SAD_TAB_RELOAD_RESTART_CHROME" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try a restart of Chrome." formatter_data="android_java">
+ Restart Chrome
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done. added Chromium/Chrome variant.
+ </message>
+ <if expr="is_win or is_linux or is_maxosx or chromeos"
+ <message name="IDS_SAD_TAB_RELOAD_RESTART_DEVICE" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try a restart of device." formatter_data="android_java">
+ Restart your computer
srahim1 2017/03/03 19:42:07 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:56 Done.
+ </message>
+ </if>
+ <if expr="is_android or is_ios"
+ <message name="IDS_SAD_TAB_RELOAD_RESTART_DEVICE" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try a restart of device." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="One of the bullet points displayed on the we
Will Harris 2017/03/03 20:22:57 Done.
+ Restart your device
+ </message>
+ </if>
+ <message name="IDS_SAD_TAB_UMA_OPTIN" desc="Text beside the checkbox to let users opt into UMA." formatter_data="android_java">
srahim1 2017/03/03 19:42:08 desc="Text that appears next to a checkbox, allowi
Will Harris 2017/03/03 20:22:57 Done.
+ Automatically send usage statistics and crash reports to Google
+ </message>
<!-- New Tab -->
<message name="IDS_NEW_TAB_TITLE"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698