Start with event_target in for loop to avoid GetEventTargeter crash.

Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700, 664617
TEST=aura_unittests

Review-Url: https://codereview.chromium.org/2730903005
Cr-Commit-Position: refs/heads/master@{#454780}
Committed: https://chromium.googlesource.com/chromium/src/+/d8b7d84c49f08b6e50de6da191264401c074c5a0

[riajiang, 2017-03-03 17:22:46]

Description was changed from

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700
TEST=will be in CL https://codereview.chromium.org/2696873002 when we
dispatch events to the root window
==========

to

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=664617
TEST=will be in CL https://codereview.chromium.org/2696873002 when we
dispatch events to the root window
==========

[riajiang, 2017-03-03 17:24:21]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 17:24:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[riajiang, 2017-03-03 17:25:46]

Description was changed from

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=664617
TEST=will be in CL https://codereview.chromium.org/2696873002 when we
dispatch events to the root window
==========

to

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700, 664617
TEST=will be in CL https://codereview.chromium.org/2696873002 when we
dispatch events to the root window
==========

[riajiang, 2017-03-03 17:25:46]

riajiang@chromium.org changed reviewers:
+ sadrul@chromium.org

[riajiang, 2017-03-03 17:27:02]

Hi sadrul@, PTAL, thanks!

[sadrul, 2017-03-03 17:32:00]

Add a test?

[commit-bot: I haz the power, 2017-03-03 18:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 18:16:19]

Dry run: This issue passed the CQ dry run.

[riajiang, 2017-03-03 22:12:01]

Patchset #2 (id:20001) has been deleted

[riajiang, 2017-03-03 22:12:25]

Description was changed from

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700, 664617
TEST=will be in CL https://codereview.chromium.org/2696873002 when we
dispatch events to the root window
==========

to

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700, 664617
TEST=aura_unittests
==========

[riajiang, 2017-03-03 22:14:49]

On 2017/03/03 17:32:00, sadrul wrote:
> Add a test?

Done. (sry I was thinking to use the tests in the other CL
https://codereview.chromium.org/2696873002...)

[riajiang, 2017-03-03 22:14:57]

The CQ bit was checked by riajiang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 22:15:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 22:57:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 22:57:55]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-03-04 02:44:00]

Thanks for the test! lgtm

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client_unittest.cc (right):

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:569: bool was_acked_ = false;
Can you get rid of this?

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:823: InputEventBasicTestEventHandler
event_handler(window_tree());
Call this root_handler (or top_level_handler)

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:831:
InputEventBasicTestWindowDelegate window_delegate(window_tree());
Call this child_delegate

[riajiang, 2017-03-04 21:31:56]

Patchset #3 (id:60001) has been deleted

[riajiang, 2017-03-04 21:34:21]

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
File ui/aura/mus/window_tree_client_unittest.cc (right):

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:569: bool was_acked_ = false;
On 2017/03/04 02:44:00, sadrul wrote:
> Can you get rid of this?

Done.

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:823: InputEventBasicTestEventHandler
event_handler(window_tree());
On 2017/03/04 02:44:00, sadrul wrote:
> Call this root_handler (or top_level_handler)

Done.

https://codereview.chromium.org/2730903005/diff/40001/ui/aura/mus/window_tree...
ui/aura/mus/window_tree_client_unittest.cc:831:
InputEventBasicTestWindowDelegate window_delegate(window_tree());
On 2017/03/04 02:44:00, sadrul wrote:
> Call this child_delegate

Done.

[riajiang, 2017-03-04 21:35:02]

The CQ bit was checked by riajiang@chromium.org

[riajiang, 2017-03-04 21:35:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2730903005/#ps80001
(title: "nits")

[commit-bot: I haz the power, 2017-03-04 21:35:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 23:08:14]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488663302592900,
"parent_rev": "f28287ce594e559cdcf49ce4ec0b1dcc9e9100ec", "commit_rev":
"d8b7d84c49f08b6e50de6da191264401c074c5a0"}

[commit-bot: I haz the power, 2017-03-04 23:08:50]

Description was changed from

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700, 664617
TEST=aura_unittests
==========

to

==========
Start with event_target in for loop to avoid GetEventTargeter crash.

Came across this while working on the CL for dispatching event to root
window if target window has already been deleted (
https://codereview.chromium.org/2696873002). If the target window we
are starting from is already the root window in that WindowTreeHost,
starting with the parent target (in this case aura::Env) for that window
would cause crash when trying to access its event targeter. Change it to
start with the event_target itself.

BUG=687700, 664617
TEST=aura_unittests

Review-Url: https://codereview.chromium.org/2730903005
Cr-Commit-Position: refs/heads/master@{#454780}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8b7d84c49f08b6e50de6da19126...
==========

[commit-bot: I haz the power, 2017-03-04 23:08:51]

Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d8b7d84c49f08b6e50de6da19126...