Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2730873003:
MD Settings: Change picture: Focus container (Closed)
|
Created:
3 years, 9 months ago by stevenjb Modified:
3 years, 9 months ago Reviewers:
tommycli CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Change picture: Focus container
BUG=668075
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2730873003
Cr-Commit-Position: refs/heads/master@{#454930}
Committed: https://chromium.googlesource.com/chromium/src/+/9c0d0b5e98c897cf7d51069c10e2fc23e1fc89aa
Patch Set 1 #
Total comments: 2
Patch Set 2 : Rebase #Messages
Total messages: 16 (11 generated)
Description was changed from ========== MD Settings: Change picture: Focus container BUG=668075 ========== to ========== MD Settings: Change picture: Focus container BUG=668075 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
stevenjb@chromium.org changed reviewers: + tommycli@chromium.org
lgtm except: https://codereview.chromium.org/2730873003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/2730873003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/change_picture.js:148: this.$.container.focus(); I think this is a solid solution, but I think it's worth adding a comment as to why we need to focus the container. (arrow keys)
https://codereview.chromium.org/2730873003/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/people_page/change_picture.js (right): https://codereview.chromium.org/2730873003/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/people_page/change_picture.js:148: this.$.container.focus(); On 2017/03/03 23:26:51, tommycli wrote: > I think this is a solid solution, but I think it's worth adding a comment as to > why we need to focus the container. (arrow keys) Good call. Done.
The CQ bit was checked by stevenjb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by stevenjb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tommycli@chromium.org Link to the patchset: https://codereview.chromium.org/2730873003/#ps40001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488826542528260,
"parent_rev": "a232126aef7735e92f6f0ad9d805cc525159a2f3", "commit_rev":
"9c0d0b5e98c897cf7d51069c10e2fc23e1fc89aa"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Change picture: Focus container BUG=668075 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Change picture: Focus container BUG=668075 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2730873003 Cr-Commit-Position: refs/heads/master@{#454930} Committed: https://chromium.googlesource.com/chromium/src/+/9c0d0b5e98c897cf7d51069c10e2... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9c0d0b5e98c897cf7d51069c10e2... |
