Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2730813002: [inspector] fixed endLine in Debugger.scriptParsed event (Closed)

Created:
3 years, 9 months ago by kozy
Modified:
3 years, 9 months ago
Reviewers:
alph, lushnikov
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fixed endLine in Debugger.scriptParsed event BUG=chromium:698077 R=lushnikov@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2730813002 Cr-Commit-Position: refs/heads/master@{#43567} Committed: https://chromium.googlesource.com/v8/v8/+/0832bae354f6001ba5b3647c42304bad1003bbaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -26 lines) Patch
M src/inspector/v8-debugger-script.cc View 1 chunk +0 lines, -5 lines 0 comments Download
A test/inspector/debugger/script-end-location.js View 1 chunk +48 lines, -0 lines 0 comments Download
A test/inspector/debugger/script-end-location-expected.txt View 1 chunk +91 lines, -0 lines 0 comments Download
M test/inspector/debugger/script-on-after-compile-expected.txt View 20 chunks +20 lines, -20 lines 0 comments Download
M test/inspector/runtime/es6-module-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
kozy
Andrey, please take a look!
3 years, 9 months ago (2017-03-03 00:17:01 UTC) #1
lushnikov
lgtm
3 years, 9 months ago (2017-03-03 00:23:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730813002/1
3 years, 9 months ago (2017-03-03 05:50:36 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 9 months ago (2017-03-03 05:50:38 UTC) #10
kozy
Alexey, please take a look. I need full superstar committer lgtm.
3 years, 9 months ago (2017-03-03 05:53:21 UTC) #13
alph
lgtm
3 years, 9 months ago (2017-03-03 06:13:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730813002/1
3 years, 9 months ago (2017-03-03 06:56:54 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 06:58:17 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0832bae354f6001ba5b3647c42304bad100...

Powered by Google App Engine
This is Rietveld 408576698