Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2730803002: Always clear TPM attestation keys on ChromeOS when removing media licenses (Closed)

Created:
3 years, 9 months ago by jrummell
Modified:
3 years, 9 months ago
Reviewers:
msramek
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always clear TPM attestation keys on ChromeOS when removing media licenses Clearing the TPM attestation keys is not dependent on plugins being enabled, (or Flash), so cleanup the #if ... #endif blocks to make this clear. BUG=692818 TEST=compiles Review-Url: https://codereview.chromium.org/2730803002 Cr-Commit-Position: refs/heads/master@{#454472} Committed: https://chromium.googlesource.com/chromium/src/+/521d60812176375b2a0f196c7ccd31f38d524efa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
jrummell
PTAL. Trivial change that un-nests #if ... #endif to make it clear they're independent.
3 years, 9 months ago (2017-03-02 22:58:32 UTC) #2
msramek
LGTM
3 years, 9 months ago (2017-03-03 01:26:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730803002/1
3 years, 9 months ago (2017-03-03 01:27:15 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 02:25:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/521d60812176375b2a0f196c7ccd...

Powered by Google App Engine
This is Rietveld 408576698