Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issue 2730783002: [chromedriver] Use disable-extensions-except on Windows and Mac. (Closed)

Created:
3 years, 9 months ago by samuong
Modified:
3 years, 9 months ago
Reviewers:
gmanikpure, stgao
CC:
chromium-reviews, samuong+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Use disable-extensions-except on Windows and Mac. BUG=chromedriver:1625 Review-Url: https://codereview.chromium.org/2730783002 Cr-Commit-Position: refs/heads/master@{#454406} Committed: https://chromium.googlesource.com/chromium/src/+/3eff24d697882f1851680e7bbd38eb18fbc20585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +13 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
samuong
Gauri, could you please test this on Windows with both Chrome 56 and 57, with ...
3 years, 9 months ago (2017-03-02 18:41:59 UTC) #2
stgao
lgtm
3 years, 9 months ago (2017-03-02 19:45:23 UTC) #3
gmanikpure
Verified on local Mac , all the tests looks good on current stable v56, beta ...
3 years, 9 months ago (2017-03-02 22:10:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730783002/1
3 years, 9 months ago (2017-03-02 22:11:54 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:26:08 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3eff24d697882f1851680e7bbd38...

Powered by Google App Engine
This is Rietveld 408576698