Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2730763003: Fix util to adjust string for locale direction (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
jif, sdefresne
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix util to adjust string for locale direction Change the util to perform according to its comment. BUG=694423 Review-Url: https://codereview.chromium.org/2730763003 Cr-Commit-Position: refs/heads/master@{#454682} Committed: https://chromium.googlesource.com/chromium/src/+/5acfe365a2d66040792eb951bf919ae178deb860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/chrome/browser/ui/util/i18n_string.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
gambard
Addressing post-landing comments.
3 years, 9 months ago (2017-03-03 08:38:12 UTC) #2
jif
lgtm
3 years, 9 months ago (2017-03-03 10:19:33 UTC) #3
sdefresne
lgtm
3 years, 9 months ago (2017-03-03 21:23:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730763003/1
3 years, 9 months ago (2017-03-03 21:24:09 UTC) #6
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 21:36:12 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5acfe365a2d66040792eb951bf91...

Powered by Google App Engine
This is Rietveld 408576698