Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2730713003: Update a couple more strong mode tests (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tests/lib_strong/html/custom/constructor_calls_created_synchronously_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib_strong/html/custom/document_register_basic_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/lib_strong/html/custom/element_upgrade_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Marks a couple of expected errors (that I don't know how best to fix) and ...
3 years, 9 months ago (2017-03-02 19:27:16 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-02 19:28:21 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-02 19:47:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe1eb38822d2795c3564c709786f55fa2a685ca4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698