Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Unified Diff: tests/lib_strong/html/custom/element_upgrade_test.dart

Issue 2730713003: Update a couple more strong mode tests (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib_strong/html/custom/document_register_basic_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib_strong/html/custom/element_upgrade_test.dart
diff --git a/tests/lib_strong/html/custom/element_upgrade_test.dart b/tests/lib_strong/html/custom/element_upgrade_test.dart
index a1f071b5c54e34c15e17ddfef5259c1c05413e92..6fd9def1c194ca5f2b6d2251a83f13d73ea9f9f1 100644
--- a/tests/lib_strong/html/custom/element_upgrade_test.dart
+++ b/tests/lib_strong/html/custom/element_upgrade_test.dart
@@ -44,13 +44,13 @@ main() {
test('created gets proxied', () {
var element = document.createElement(FooElement.tag);
expect(element is FooElement, isTrue);
- expect(element.initializedField, 666);
+ expect((element as FooElement).initializedField, 666);
expect(element.text, 'constructed');
js.context.callMethod('validateIsFoo', [element]);
- expect(element.doSomething(), 'didSomething');
- expect(element.fooCreated, true);
+ expect((element as FooElement).doSomething(), 'didSomething');
+ expect((element as FooElement).fooCreated, true);
});
test('dart constructor works', () {
@@ -71,7 +71,7 @@ main() {
test('cannot upgrade interfaces', () {
expect(() {
- upgrader.upgrade(new HtmlElementInterface());
+ upgrader.upgrade(new HtmlElementInterface()); /// compile-time error
}, throws);
});
@@ -115,7 +115,7 @@ main() {
});
}
-class HtmlElementInterface implements HtmlElement {
+class HtmlElementInterface implements HtmlElement { /// compile-time error
HtmlElementInterface.created();
}
« no previous file with comments | « tests/lib_strong/html/custom/document_register_basic_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698