Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2730713002: Fix WebRtcAudioDebugRecordingsBrowserTest. (Closed)

Created:
3 years, 9 months ago by Henrik Grunell
Modified:
3 years, 9 months ago
Reviewers:
Guido Urdaneta, o1ka
CC:
chromium-reviews, jam, darin-cc_chromium.org, perkj_chrome
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WebRtcAudioDebugRecordingsBrowserTest. https://chromium.googlesource.com/chromium/src/+/086a4113b499025bdd7db2c19a10bd8cd34a5997 broke https://build.chromium.org/p/chromium.webrtc/builders/Win10%20Tester/ (Only that particular Win 10 bot.) The short-term fix to get the bot green is to revert to not check expectations of return value when deleting files. Long-term it should be investigated why this happens. Perhaps explicitly disabling would avoid the issue. BUG=697845 TBR=olka@chromium.org,guidou@chromium.org Review-Url: https://codereview.chromium.org/2730713002 Cr-Commit-Position: refs/heads/master@{#454247} Committed: https://chromium.googlesource.com/chromium/src/+/6a964e37a2eea4ac09dabde38018d675fae85b1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M content/browser/webrtc/webrtc_audio_debug_recordings_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Henrik Grunell
3 years, 9 months ago (2017-03-02 13:03:00 UTC) #5
Henrik Grunell
3 years, 9 months ago (2017-03-02 13:03:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730713002/1
3 years, 9 months ago (2017-03-02 13:39:02 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 13:43:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a964e37a2eea4ac09dabde38018...

Powered by Google App Engine
This is Rietveld 408576698