chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml - Issue 2730703003: Change CBD layout and texts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml

Issue 2730703003: Change CBD layout and texts (Closed)

Patch Set: cleanup test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout-sw360dp/preference_spinner_custom.xml ('k') | chrome/android/java/res/layout/preference_spinner_custom.xml » ('j') | chrome/android/java/res/layout/preference_spinner_custom.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml

diff --git a/chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml b/chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml

new file mode 100644

index 0000000000000000000000000000000000000000..2002ce28294808240a1668578ff8c1c9beb48307

--- /dev/null

+++ b/chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml

@@ -0,0 +1,12 @@

+<?xml version="1.0" encoding="utf-8"?>

+ Use of this source code is governed by a BSD-style license that can be

+ found in the LICENSE file. -->

+<LinearLayout

+ xmlns:android="http://schemas.android.com/apk/res/android"

+ android:layout_height="wrap_content"

+ android:layout_width="match_parent"

+ android:paddingBottom="8dp">

+ <View style="@style/Divider"/>

Theresa 2017/03/24 17:15:36 Does this need to be wrapped in a LinearLayout? Yo

dullweber 2017/03/27 14:11:04 I tried paddingBottom directly on the View but it

+</LinearLayout>