chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml - Issue 2730703003: Change CBD layout and texts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml

Issue 2730703003: Change CBD layout and texts (Closed)

Patch Set: cleanup test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <LinearLayout

	7 xmlns:android="http://schemas.android.com/apk/res/android"

	8 android:layout_height="wrap_content"

	9 android:layout_width="match_parent"

	10 android:paddingBottom="8dp">

	11 <View style="@style/Divider"/>
	Theresa 2017/03/24 17:15:36 Does this need to be wrapped in a LinearLayout? Yo Does this need to be wrapped in a LinearLayout? You should be able to add padding directly to the View tag. dullweber 2017/03/27 14:11:04 I tried paddingBottom directly on the View but it Show quoted text On 2017/03/24 17:15:36, Theresa wrote: > Does this need to be wrapped in a LinearLayout? You should be able to add > padding directly to the View tag. I tried paddingBottom directly on the View but it isn't applied and the Browsing history checkbox gets too close to the divider.
	12 </LinearLayout>

OLD	NEW