Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2730693002: PermissionUtil::GetPermissionType needs to handle MIDI (Closed)

Created:
3 years, 9 months ago by Takashi Toyoshima
Modified:
3 years, 9 months ago
Reviewers:
Timothy Loh, raymes
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, Timothy Loh
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PermissionUtil::GetPermissionType needs to handle MIDI After the recent PermissionManager's change, it calls GetPermissionType even for CONTENT_SETTING_TYPE_MIDI. BUG=697771 Review-Url: https://codereview.chromium.org/2730693002 Cr-Commit-Position: refs/heads/master@{#454231} Committed: https://chromium.googlesource.com/chromium/src/+/b0d271768d0a592227d753f4cf60399c4dd2af4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/permissions/permission_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Takashi Toyoshima
PTAL
3 years, 9 months ago (2017-03-02 09:00:53 UTC) #2
raymes
Thanks for the CL - sorry for breakage!
3 years, 9 months ago (2017-03-02 10:57:29 UTC) #7
raymes
lgtm
3 years, 9 months ago (2017-03-02 10:57:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730693002/1
3 years, 9 months ago (2017-03-02 10:57:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730693002/1
3 years, 9 months ago (2017-03-02 10:58:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/b0d271768d0a592227d753f4cf60399c4dd2af4f
3 years, 9 months ago (2017-03-02 11:03:42 UTC) #16
Timothy Loh
3 years, 9 months ago (2017-03-03 02:33:01 UTC) #18
Message was sent while issue was closed.
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698