Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp

Issue 2730683004: Avoid name collision for secondsPerHour/secondsPerMinute (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
diff --git a/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp b/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
index 6a487d6e1b8561c2a398685201dbb7e879db93f2..4a4ac657ccc0c8c1a8c2f3d39cf7111a6f0a2036 100644
--- a/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
+++ b/third_party/WebKit/Source/core/html/MediaFragmentURIParser.cpp
@@ -31,8 +31,6 @@
namespace blink {
-const int secondsPerHour = 3600;
-const int secondsPerMinute = 60;
const unsigned nptIdentiferLength = 4; // "npt:"
static String collectDigits(const LChar* input,
@@ -258,6 +256,8 @@ bool MediaFragmentURIParser::parseNPTTime(const LChar* timeString,
// npt-mm = 2DIGIT ; 0-59
// npt-ss = 2DIGIT ; 0-59
+ const int secondsPerHour = 3600;
+ const int secondsPerMinute = 60;
fs 2017/03/02 15:52:15 Maybe just fold these into their (single) use inst
String digits1 = collectDigits(timeString, length, offset);
int value1 = digits1.toInt();
if (offset >= length || timeString[offset] == ',') {

Powered by Google App Engine
This is Rietveld 408576698