Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.h

Issue 2730683002: Add CSS Transition support to registered custom properties (Closed)
Patch Set: Rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.h
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.h b/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
index 54715efbbe25490663c07000912199a41071e74b..9fec4deb09476b7cfd9212ea5af511cf1c2fa93b 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.h
@@ -78,7 +78,9 @@ class CSSAnimations final {
const ComputedStyle&,
const ComputedStyle* parentStyle,
bool wasViewportChanged);
+ enum class PropertyPass { Custom, Standard };
suzyh_UTC10 (ex-contributor) 2017/03/10 04:08:28 Please add a comment to describe what this enum me
alancutter (OOO until 2018) 2017/03/12 23:52:07 Done.
static void calculateTransitionUpdate(CSSAnimationUpdate&,
+ PropertyPass,
const Element* animatingElement,
const ComputedStyle&);
static void snapshotCompositorKeyframes(Element&,
@@ -161,10 +163,15 @@ class CSSAnimations final {
const ComputedStyle& oldStyle;
const ComputedStyle& style;
const TransitionMap* activeTransitions;
- std::bitset<numCSSProperties>& listedProperties;
+ HashSet<PropertyHandle>& listedProperties;
const CSSTransitionData& transitionData;
};
+ static void calculateTransitionUpdateForCustomProperty(
+ TransitionUpdateState&,
+ const CSSTransitionData::TransitionProperty&,
+ size_t transitionIndex);
+
static void calculateTransitionUpdateForStandardProperty(
TransitionUpdateState&,
const CSSTransitionData::TransitionProperty&,
@@ -179,6 +186,7 @@ class CSSAnimations final {
const Element* animatingElement);
static void calculateTransitionActiveInterpolations(
CSSAnimationUpdate&,
+ PropertyPass,
const Element* animatingElement);
class AnimationEventDelegate final

Powered by Google App Engine
This is Rietveld 408576698