Add CSS Transition support to registered custom properties

third_party/WebKit/Source/core/animation/css/CSSAnimations.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 60 matching lines @@
                                        const ComputedStyle&,
                                        ComputedStyle* parentStyle,
                                        StyleResolver*);
   static void calculateCompositorAnimationUpdate(
       CSSAnimationUpdate&,
       const Element* animatingElement,
       Element&,
       const ComputedStyle&,
       const ComputedStyle* parentStyle,
       bool wasViewportChanged);
+  enum class PropertyPass { Custom, Standard };

[suzyh_UTC10 (ex-contributor), 2017/03/10 04:08:28]

Please add a comment to describe what this enum means.

[alancutter (OOO until 2018), 2017/03/12 23:52:07]

Done.

   static void calculateTransitionUpdate(CSSAnimationUpdate&,
+                                        PropertyPass,
                                         const Element* animatingElement,
                                         const ComputedStyle&);
   static void snapshotCompositorKeyframes(Element&,
                                           CSSAnimationUpdate&,
                                           const ComputedStyle&,
                                           const ComputedStyle* parentStyle);
 
   void setPendingUpdate(const CSSAnimationUpdate& update) {
     clearPendingUpdate();
     m_pendingUpdate.copy(update);
@@ skipping 62 matching lines @@
 
   ActiveInterpolationsMap m_previousActiveInterpolationsForAnimations;
 
   struct TransitionUpdateState {
     STACK_ALLOCATED();
     CSSAnimationUpdate& update;
     Member<const Element> animatingElement;
     const ComputedStyle& oldStyle;
     const ComputedStyle& style;
     const TransitionMap* activeTransitions;
-    std::bitset<numCSSProperties>& listedProperties;
+    HashSet<PropertyHandle>& listedProperties;
     const CSSTransitionData& transitionData;
   };
 
+  static void calculateTransitionUpdateForCustomProperty(
+      TransitionUpdateState&,
+      const CSSTransitionData::TransitionProperty&,
+      size_t transitionIndex);
+
   static void calculateTransitionUpdateForStandardProperty(
       TransitionUpdateState&,
       const CSSTransitionData::TransitionProperty&,
       size_t transitionIndex);
 
   static void calculateTransitionUpdateForProperty(TransitionUpdateState&,
                                                    const PropertyHandle&,
                                                    size_t transitionIndex);
 
   static void calculateAnimationActiveInterpolations(
       CSSAnimationUpdate&,
       const Element* animatingElement);
   static void calculateTransitionActiveInterpolations(
       CSSAnimationUpdate&,
+      PropertyPass,
       const Element* animatingElement);
 
   class AnimationEventDelegate final
       : public AnimationEffectReadOnly::EventDelegate {
    public:
     AnimationEventDelegate(Element* animationTarget, const AtomicString& name)
         : m_animationTarget(animationTarget),
           m_name(name),
           m_previousPhase(AnimationEffectReadOnly::PhaseNone),
           m_previousIteration(nullValue()) {}
@@ skipping 37 matching lines @@
 
     Member<Element> m_transitionTarget;
     PropertyHandle m_property;
     AnimationEffectReadOnly::Phase m_previousPhase;
   };
 };
 
 }  // namespace blink
 
 #endif