tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h - Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check. (Closed)

Patch Set: retire GC option flag also Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

diff --git a/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h b/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

index 0df51cd597cc73c3f310ba54e6fb174a3f8a2a29..fee044b7b1a3e60b31e690f9a884c5c0069f7666 100644

--- a/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

+++ b/tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h

@@ -12,9 +12,6 @@

struct BlinkGCPluginOptions {

bool dump_graph = false;

- // If |true|, emit warning if stack allocated class types provide

- // a trace method.

- bool warn_stack_allocated_trace_method = false;

// If |true|, emit warning for class types which derive from from

// GarbageCollectedFinalized<> when just GarbageCollected<> will do.

bool warn_unneeded_finalizer = false;