tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h - Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h

Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check. (Closed)

Patch Set: retire GC option flag also Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h ('k') | tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h

diff --git a/tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h b/tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h

deleted file mode 100644

index 3891d2a86343689085d918880035b4c96dd84bb5..0000000000000000000000000000000000000000

--- a/tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h

+++ /dev/null

@@ -1,26 +0,0 @@

-// Use of this source code is governed by a BSD-style license that can be

-// found in the LICENSE file.

-#ifndef STACK_ALLOCATED_H_

-#define STACK_ALLOCATED_H_

-#include "heap/stubs.h"

-namespace blink {

-class HeapObject;

-class StackObject {

- STACK_ALLOCATED();

- // Redundant trace() method, but warning/error disabled.

- void trace(Visitor* visitor) { visitor->trace(m_obj); }

-private:

- Member<HeapObject> m_obj; // Does not need tracing.

-};

-#endif