Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2730663003: [spellcheck] Narrowly re-enabled some unit tests for Windows (Closed)

Created:
3 years, 9 months ago by Kevin Bailey
Modified:
3 years, 9 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[spellcheck] Narrowly re-enabled some unit tests for Windows Only a few of the languages in a unit test were taking so long that they timed out. I re-enabled the others. The activity that is taking a long time is the reading of the affix file. There doesn't appear to be anything intrinsically wrong with it. While en-US has 205 lines in its affix file, e.g. ko-KO has 78,256. BUG=678300 Review-Url: https://codereview.chromium.org/2730663003 Cr-Commit-Position: refs/heads/master@{#454932} Committed: https://chromium.googlesource.com/chromium/src/+/13934c3f62b6e223d085e10a3e2727c6701333e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M components/spellcheck/renderer/spellcheck_unittest.cc View 9 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Kevin Bailey
groby@, A small change. Can you take a look?
3 years, 9 months ago (2017-03-02 18:42:06 UTC) #3
Kevin Bailey
On 2017/03/02 18:42:06, Kevin Bailey wrote: > groby@, > > A small change. Can you ...
3 years, 9 months ago (2017-03-06 18:28:12 UTC) #4
groby-ooo-7-16
LGTM Is there a tracking bug for re-enabling the rest?
3 years, 9 months ago (2017-03-06 18:52:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730663003/1
3 years, 9 months ago (2017-03-06 19:32:53 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 20:12:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/13934c3f62b6e223d085e10a3e27...

Powered by Google App Engine
This is Rietveld 408576698