Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2730653002: [WebAPK]: Don't do fake install to determine whether Google Play supports WebAPK (Closed)

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
dominickn, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebAPK]: Don't do fake install to determine whether Google Play supports WebAPK We currently do a fake WebAPK install in order to determine whether Google Play supports WebAPKs. With https://codereview.chromium.org/2721203004/ we add a webapp to the homescreen if the WebAPK install fails. This makes the fake WebAPK install no longer necessary BUG=696132 Review-Url: https://codereview.chromium.org/2730653002 Cr-Commit-Position: refs/heads/master@{#454395} Committed: https://chromium.googlesource.com/chromium/src/+/54d3ba6d6186cd35ef2b124d8c65eab7b2d7cb5e

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge branch 'launch_webapp' into launch_webapp_simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/init/ProcessInitializationHandler.java View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 1 3 chunks +7 lines, -27 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
pkotwicz
Dominick, can you please take a look?
3 years, 9 months ago (2017-03-02 04:06:30 UTC) #3
dominickn
https://codereview.chromium.org/2730653002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java File chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java (right): https://codereview.chromium.org/2730653002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java#newcode60 chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java:60: public static int computeGooglePlayInstallState() { This can be private ...
3 years, 9 months ago (2017-03-02 04:11:51 UTC) #4
pkotwicz
Dominick, can you please take another look?
3 years, 9 months ago (2017-03-02 04:37:14 UTC) #5
dominickn
lgtm, thanks
3 years, 9 months ago (2017-03-02 04:40:13 UTC) #6
pkotwicz
dfalcantara@ for ProcessInitializationHandler.java OWNERS
3 years, 9 months ago (2017-03-02 20:28:50 UTC) #8
gone
lgtm
3 years, 9 months ago (2017-03-02 21:14:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730653002/20001
3 years, 9 months ago (2017-03-02 21:21:18 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:06:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54d3ba6d6186cd35ef2b124d8c65...

Powered by Google App Engine
This is Rietveld 408576698