[Devtools] Inline _drawSimplifiedBarDetails in NetworkWaterfallColumn.js

[Devtools] Inline _drawSimplifiedBarDetails in NetworkWaterfallColumn.js

This patch simply inlines _drawSimplifiedBarDetails. This is because
this function's functionality will be reduced in future patches and will
make it eassier to review follup patches.

R=caseq
BUG=697668
Review-Url: https://codereview.chromium.org/2730633002
Cr-Commit-Position: refs/heads/master@{#455959}
Committed: https://chromium.googlesource.com/chromium/src/+/5856f08dd586fcc0700e6bc079d5c7099ae5358c

[allada, 2017-03-02 02:50:28]

PTL - You should be able to do a diff on the moved text to ensure they are the
same (which they should be). Followup patch will fix variable names.

[caseq, 2017-03-03 06:03:52]

lgtm % comment

https://codereview.chromium.org/2730633002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2730633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:482:
const leftText = labels.left;
please replaces with vars :(

[allada, 2017-03-03 19:46:56]

done.

https://codereview.chromium.org/2730633002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
(right):

https://codereview.chromium.org/2730633002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js:482:
const leftText = labels.left;
On 2017/03/03 06:03:52, caseq wrote:
> please replaces with vars :(

Done.

[allada, 2017-03-09 01:45:34]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 01:46:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 01:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 01:50:08]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[allada, 2017-03-10 00:50:26]

The CQ bit was checked by allada@chromium.org

[allada, 2017-03-10 00:50:27]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2730633002/#ps40001
(title: "Merge remote-tracking branch 'origin/master' into
z-round1-commitable-4-split")

[commit-bot: I haz the power, 2017-03-10 00:51:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 02:14:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1489107026915790,
"parent_rev": "e2521352441e0a396674c0d190e2c2f836ece010", "commit_rev":
"5856f08dd586fcc0700e6bc079d5c7099ae5358c"}

[commit-bot: I haz the power, 2017-03-10 02:15:15]

Description was changed from

==========
[Devtools] Inline _drawSimplifiedBarDetails in NetworkWaterfallColumn.js

This patch simply inlines _drawSimplifiedBarDetails. This is because
this function's functionality will be reduced in future patches and will
make it eassier to review follup patches.

R=caseq
BUG=697668
==========

to

==========
[Devtools] Inline _drawSimplifiedBarDetails in NetworkWaterfallColumn.js

This patch simply inlines _drawSimplifiedBarDetails. This is because
this function's functionality will be reduced in future patches and will
make it eassier to review follup patches.

R=caseq
BUG=697668

Review-Url: https://codereview.chromium.org/2730633002
Cr-Commit-Position: refs/heads/master@{#455959}
Committed:
https://chromium.googlesource.com/chromium/src/+/5856f08dd586fcc0700e6bc079d5...
==========

[commit-bot: I haz the power, 2017-03-10 02:15:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5856f08dd586fcc0700e6bc079d5...