Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2730623005: Make SSLConfigManager notify clients if the SHA-1 policy changes (Closed)

Created:
3 years, 9 months ago by Ryan Sleevi
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Make SSLConfigManager notify clients if the SHA-1 policy changes An oversight in the comparator for the SSLConfigManager that handles the logic for determining when an SSLConfig is "new" (and thus should invalidate all existing SSLConfigs) meant that changes to the SHA-1 policy for local anchors wouldn't be immediately propagated. BUG=697154 Review-Url: https://codereview.chromium.org/2723783002 Cr-Commit-Position: refs/heads/master@{#453772} (cherry picked from commit 39f9eb3f5301f73d385c6d65601c60dba4fae63e) Review-Url: https://codereview.chromium.org/2730623005 . Cr-Commit-Position: refs/branch-heads/2987@{#746} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/da57f51fe86456e1e909011e8495d089f21516cb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -10 lines) Patch
M net/ssl/ssl_config_service.cc View 2 chunks +14 lines, -10 lines 0 comments Download
M net/ssl/ssl_config_service_unittest.cc View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ryan Sleevi
3 years, 9 months ago (2017-03-03 02:30:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da57f51fe86456e1e909011e8495d089f21516cb.

Powered by Google App Engine
This is Rietveld 408576698