Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2730623003: Update views::Textfield cursor color on text color change (Closed)

Created:
3 years, 9 months ago by mmarkowicz
Modified:
3 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, tfarina, yiyix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update views::Textfield cursor color on text color change views::Textfield::SetTextColor should apply new color to the cursor as well. Currently this will happen but only after Textfield::OnNativeThemeChanged is triggered in some way. BUG=697939 Review-Url: https://codereview.chromium.org/2730623003 Cr-Commit-Position: refs/heads/master@{#454616} Committed: https://chromium.googlesource.com/chromium/src/+/741bad136249946504139ca35420d78a312762f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/textfield/textfield.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mmarkowicz
3 years, 9 months ago (2017-03-03 09:48:58 UTC) #2
msw
lgtm. +cc yiyix for fyi
3 years, 9 months ago (2017-03-03 16:57:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730623003/1
3 years, 9 months ago (2017-03-03 17:02:13 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 17:51:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/741bad136249946504139ca35420...

Powered by Google App Engine
This is Rietveld 408576698