Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2730573004: Revert of Migrate Object.prototype.valueOf to CSA (Closed)

Created:
3 years, 9 months ago by Michael Achenbach
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Migrate Object.prototype.valueOf to CSA (patchset #4 id:80001 of https://codereview.chromium.org/2724833002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/13900 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > Migrate Object.prototype.valueOf to CSA > > BUG=v8:6005 > > Review-Url: https://codereview.chromium.org/2724833002 > Cr-Commit-Position: refs/heads/master@{#43539} > Committed: https://chromium.googlesource.com/v8/v8/+/f93b27e639cca6a93ce9b6c535ece9b6cc399a01 TBR=bmeurer@chromium.org,yangguo@chromium.org,loorongjie@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6005 Review-Url: https://codereview.chromium.org/2730573004 Cr-Commit-Position: refs/heads/master@{#43547} Committed: https://chromium.googlesource.com/v8/v8/+/d7cb3cfc91eb63ed3879a27c730b325faed814dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M src/bootstrapper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/builtins/builtins-object.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/debug/debug-evaluate.cc View 2 chunks +1 line, -3 lines 0 comments Download
M src/js/v8natives.js View 3 chunks +11 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of Migrate Object.prototype.valueOf to CSA
3 years, 9 months ago (2017-03-02 14:26:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730573004/1
3 years, 9 months ago (2017-03-02 14:26:37 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 14:26:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d7cb3cfc91eb63ed3879a27c730b325faed...

Powered by Google App Engine
This is Rietveld 408576698