third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp - Issue 2730573003: Moved FrameHost::m_visualViewport to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

diff --git a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

index 230c82bb828ac0a727423948efa903f6ea22a392..a9f16e041edb1076e8259e8496ab8e1f3da6636f 100644

--- a/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

+++ b/third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp

@@ -151,8 +151,7 @@ TEST_F(ExternalPopupMenuTest, PopupAccountsForVisualViewportTransform) {

LayoutMenuList* menuList = toLayoutMenuList(select->layoutObject());

ASSERT_TRUE(menuList);

- VisualViewport& visualViewport =

- webView()->page()->frameHost().visualViewport();

+ VisualViewport& visualViewport = webView()->page()->visualViewport();

IntRect rectInDocument = menuList->absoluteBoundingBoxRect();