Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2730523002: Add libgtk-3 to install-build-deps.sh (Closed)

Created:
3 years, 9 months ago by Tom (Use chromium acct)
Modified:
3 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Lei Zhang, Elliot Glaysher
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add libgtk-3 to install-build-deps.sh This CL adds the following packages to install-build-deps.sh: libgtk-3-dev libgtk-3-0 libgtk-3-0-dbg libgtk-3-0:i386 In addition, it also refactors dev_list, lib_list, dbg_list, and nacl_list so that each package is on a separate line. It was getting ridiculous reformatting everything every time a new package was added. BUG=695541 R=dpranke@chromium.org CC=thestig@chromium.org,erg@chromium.org Review-Url: https://codereview.chromium.org/2730523002 Cr-Commit-Position: refs/heads/master@{#454118} Committed: https://chromium.googlesource.com/chromium/src/+/20032a5cd3037ac303100cae6585e279d6908c23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -35 lines) Patch
M build/install-build-deps.sh View 3 chunks +172 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom (Use chromium acct)
3 years, 9 months ago (2017-03-02 00:14:08 UTC) #2
Dirk Pranke
lgtm
3 years, 9 months ago (2017-03-02 00:14:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730523002/1
3 years, 9 months ago (2017-03-02 00:15:30 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 00:29:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20032a5cd3037ac303100cae6585...

Powered by Google App Engine
This is Rietveld 408576698