Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: BUILD.gn

Issue 2730473002: Build addr2line-pdb from tcmalloc for use in memory-infra symbolization (Closed)
Patch Set: reformated Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/tcmalloc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1c9bb954acc172fdc2c56d5fd2b2375273cbb6ae..f54da3d66f0314a6cdf1418b20f999b75c0e2322 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -754,6 +754,10 @@ group("gn_only") {
}
}
+ if (is_win) {
+ deps += [ "//third_party/tcmalloc:addr2line-pdb" ]
scottmg 2017/03/03 00:20:24 There's no such thing as gyp any more so this shou
awong 2017/03/06 18:45:52 I was told to move it down hear in an earlier revi
erikchen 2017/03/06 19:31:17 I'm the one who asked for this move. This group is
+ }
+
if (is_linux && !is_chromeos && !is_chromecast) {
# TODO(GYP): Figure out if any of these should be in gn_all
# and figure out how cross-platform they are
« no previous file with comments | « no previous file | third_party/tcmalloc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698