Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: BUILD.gn

Issue 2730473002: Build addr2line-pdb from tcmalloc for use in memory-infra symbolization (Closed)
Patch Set: reformated Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/tcmalloc/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 736 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 # component builds, due to duplicate symbol definitions. 747 # component builds, due to duplicate symbol definitions.
748 if (is_win && is_component_build) { 748 if (is_win && is_component_build) {
749 deps -= [ "//media/mojo/services:media_service_unittests" ] 749 deps -= [ "//media/mojo/services:media_service_unittests" ]
750 } 750 }
751 751
752 if (use_ozone && is_chromeos) { 752 if (use_ozone && is_chromeos) {
753 deps += [ "//services/ui/display:display_service_unittests" ] 753 deps += [ "//services/ui/display:display_service_unittests" ]
754 } 754 }
755 } 755 }
756 756
757 if (is_win) {
758 deps += [ "//third_party/tcmalloc:addr2line-pdb" ]
scottmg 2017/03/03 00:20:24 There's no such thing as gyp any more so this shou
awong 2017/03/06 18:45:52 I was told to move it down hear in an earlier revi
erikchen 2017/03/06 19:31:17 I'm the one who asked for this move. This group is
759 }
760
757 if (is_linux && !is_chromeos && !is_chromecast) { 761 if (is_linux && !is_chromeos && !is_chromecast) {
758 # TODO(GYP): Figure out if any of these should be in gn_all 762 # TODO(GYP): Figure out if any of these should be in gn_all
759 # and figure out how cross-platform they are 763 # and figure out how cross-platform they are
760 deps += [ 764 deps += [
761 ":gn_mojo_targets", 765 ":gn_mojo_targets",
762 "//chrome/installer/util:strings", 766 "//chrome/installer/util:strings",
763 "//chrome/tools/convert_dict", 767 "//chrome/tools/convert_dict",
764 "//components/constrained_window:unit_tests", 768 "//components/constrained_window:unit_tests",
765 "//components/filesystem:filesystem_service_unittests", 769 "//components/filesystem:filesystem_service_unittests",
766 "//components/leveldb:leveldb_service_unittests", 770 "//components/leveldb:leveldb_service_unittests",
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
1108 assert(target_name != "") # Mark as used. 1112 assert(target_name != "") # Mark as used.
1109 sources = invoker.actual_sources 1113 sources = invoker.actual_sources
1110 assert( 1114 assert(
1111 sources == invoker.actual_sources, 1115 sources == invoker.actual_sources,
1112 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1116 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1113 } 1117 }
1114 1118
1115 assert_valid_out_dir("_unused") { 1119 assert_valid_out_dir("_unused") {
1116 actual_sources = [ "$root_build_dir/foo" ] 1120 actual_sources = [ "$root_build_dir/foo" ]
1117 } 1121 }
OLDNEW
« no previous file with comments | « no previous file | third_party/tcmalloc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698