Transfer variation axis coordinates including tags

Transfer variation axis coordinates including tags

Skia may not always return the axis coordinates in order. Hence we
should transfer tags and axis values, not only axis values in an assumed
order. Doing this, we can also skip the additional copying and cast the
data from Skia to HarfBuzz types straight away. We are ensuring the
validity of the cast with a static_assert comparing the types.

BUG=674879
Review-Url: https://codereview.chromium.org/2730443002
Cr-Commit-Position: refs/heads/master@{#454039}
Committed: https://chromium.googlesource.com/chromium/src/+/1ee8493dad2494e89b2417453c030da69f89137a

[drott, 2017-03-01 19:54:46]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 19:55:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-03-01 19:55:51]

drott@chromium.org changed reviewers:
+ bungeman@chromium.org, eae@chromium.org

[bungeman-chromium, 2017-03-01 20:15:31]

lgtm

[drott, 2017-03-01 20:16:25]

The CQ bit was unchecked by drott@chromium.org

[drott, 2017-03-01 20:16:28]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-03-01 20:16:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2017-03-01 21:07:01]

LGTM

[commit-bot: I haz the power, 2017-03-01 21:29:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488399388236300, "parent_rev":
"0ae3030718bc7e0673868ae81b33a3cccd663e62", "commit_rev":
"1ee8493dad2494e89b2417453c030da69f89137a"}

[commit-bot: I haz the power, 2017-03-01 21:29:46]

Description was changed from

==========
Transfer variation axis coordinates including tags

Skia may not always return the axis coordinates in order. Hence we
should transfer tags and axis values, not only axis values in an assumed
order. Doing this, we can also skip the additional copying and cast the
data from Skia to HarfBuzz types straight away. We are ensuring the
validity of the cast with a static_assert comparing the types.

BUG=674879
==========

to

==========
Transfer variation axis coordinates including tags

Skia may not always return the axis coordinates in order. Hence we
should transfer tags and axis values, not only axis values in an assumed
order. Doing this, we can also skip the additional copying and cast the
data from Skia to HarfBuzz types straight away. We are ensuring the
validity of the cast with a static_assert comparing the types.

BUG=674879

Review-Url: https://codereview.chromium.org/2730443002
Cr-Commit-Position: refs/heads/master@{#454039}
Committed:
https://chromium.googlesource.com/chromium/src/+/1ee8493dad2494e89b2417453c03...
==========

[commit-bot: I haz the power, 2017-03-01 21:29:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1ee8493dad2494e89b2417453c03...