Convert layout test password-delete-performance.html to performance test

Convert layout test password-delete-performance.html to performance test

This patch converts layout test "password-delete-performance.html" to
performance test since the purpose of this test if measuring performance of
deleting character in password field.

Test results:
# 56.0.2924.87 (Official Build) (64-bit)
 avg 30.719000000000015 ms
 median 30.617500000000007 ms
 stdev 1.5581978456909256 ms

# 58.0.3024.0 (Official Build) canary (64-bit)
 avg 944.1679999999999 ms
 median 944.2900000000004 ms
 stdev 5.375929882845524 ms

BUG=474121
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2730433004
Cr-Commit-Position: refs/heads/master@{#454818}
Committed: https://chromium.googlesource.com/chromium/src/+/42bca36878d20e2bf6f27fb091d61d01ddc516a9

[yosin_UTC9, 2017-03-02 09:00:37]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 09:00:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-03-02 09:06:03]

On 2017/03/02 09:00:55, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Could you describe current score?

[yoichio, 2017-03-02 09:07:41]

yoichio@chromium.org changed reviewers:
+ yoichio@chromium.org

[yoichio, 2017-03-02 09:07:42]

https://codereview.chromium.org/2730433004/diff/1/third_party/WebKit/Performa...
File third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html
(right):

https://codereview.chromium.org/2730433004/diff/1/third_party/WebKit/Performa...
third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html:10:
PerfTestRunner.measureRunsPerSecond({
Could you use |PerfTestRunner.measureTime| instead?
It is very understandable for measuring this kind of one action.

[yosin_UTC9, 2017-03-02 09:17:04]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 09:17:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-03-02 09:18:40]

Description was changed from

==========
2017-03-02T17:52:37

2017-03-02T17:52:22

BUG=
==========

to

==========
Convert layout test password-delete-performance.html to performance test

This patch converts layout test "password-delete-performance.html" to
performance test since the purpose of this test if measuring performance of
deleting character in password field.

BUG=474121
TEST=n/a; no behavior change
==========

[yosin_UTC9, 2017-03-02 09:19:03]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org

[yosin_UTC9, 2017-03-02 09:19:04]

PTAL

https://codereview.chromium.org/2730433004/diff/1/third_party/WebKit/Performa...
File third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html
(right):

https://codereview.chromium.org/2730433004/diff/1/third_party/WebKit/Performa...
third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html:10:
PerfTestRunner.measureRunsPerSecond({
On 2017/03/02 at 09:07:42, yoichio wrote:
> Could you use |PerfTestRunner.measureTime| instead?
> It is very understandable for measuring this kind of one action.

Yay! It is more readable.
Thanks!

[commit-bot: I haz the power, 2017-03-02 10:26:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 10:26:41]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-02 23:40:21]

lgtm

[yoichio, 2017-03-03 02:07:22]

To understand current performance,
 please add avg time on your environment in description.

https://codereview.chromium.org/2730433004/diff/20001/third_party/WebKit/Perf...
File third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html
(right):

https://codereview.chromium.org/2730433004/diff/20001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html:14:
hidden.innerHTML= '<p>foo bar</p>'.repeat(999);
This line can be before mesureTime?

https://codereview.chromium.org/2730433004/diff/20001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html:18:
password.value = 'a';
In the setup, set password.value = 'abcdfef..."
end in the run(), just delete 10 times?

[yosin_UTC9, 2017-03-03 09:06:47]

Description was changed from

==========
Convert layout test password-delete-performance.html to performance test

This patch converts layout test "password-delete-performance.html" to
performance test since the purpose of this test if measuring performance of
deleting character in password field.

BUG=474121
TEST=n/a; no behavior change
==========

to

==========
Convert layout test password-delete-performance.html to performance test

This patch converts layout test "password-delete-performance.html" to
performance test since the purpose of this test if measuring performance of
deleting character in password field.

Test results:
# 56.0.2924.87 (Official Build) (64-bit)
 avg 30.719000000000015 ms
 median 30.617500000000007 ms
 stdev 1.5581978456909256 ms

# 58.0.3024.0 (Official Build) canary (64-bit)
 avg 944.1679999999999 ms
 median 944.2900000000004 ms
 stdev 5.375929882845524 ms

BUG=474121
TEST=n/a; no behavior change
==========

[yosin_UTC9, 2017-03-03 09:07:13]

PTAL

- Update test as suggested
- Put test results in description

https://codereview.chromium.org/2730433004/diff/20001/third_party/WebKit/Perf...
File third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html
(right):

https://codereview.chromium.org/2730433004/diff/20001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html:14:
hidden.innerHTML= '<p>foo bar</p>'.repeat(999);
On 2017/03/03 at 02:07:22, yoichio wrote:
> This line can be before mesureTime?

Done.

https://codereview.chromium.org/2730433004/diff/20001/third_party/WebKit/Perf...
third_party/WebKit/PerformanceTests/Editing/delete-in-password-field.html:18:
password.value = 'a';
On 2017/03/03 at 02:07:22, yoichio wrote:
> In the setup, set password.value = 'abcdfef..."
> end in the run(), just delete 10 times?

Done.

[yoichio, 2017-03-06 01:59:32]

lgtm

[yosin_UTC9, 2017-03-06 02:14:33]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-06 02:14:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2730433004/#ps40001
(title: "2017-03-03T18:04:33")

[commit-bot: I haz the power, 2017-03-06 02:14:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 03:38:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488766473247730,
"parent_rev": "601ab6b021ca49678a407f4feb66a313318c18aa", "commit_rev":
"42bca36878d20e2bf6f27fb091d61d01ddc516a9"}

[commit-bot: I haz the power, 2017-03-06 03:39:21]

Description was changed from

==========
Convert layout test password-delete-performance.html to performance test

This patch converts layout test "password-delete-performance.html" to
performance test since the purpose of this test if measuring performance of
deleting character in password field.

Test results:
# 56.0.2924.87 (Official Build) (64-bit)
 avg 30.719000000000015 ms
 median 30.617500000000007 ms
 stdev 1.5581978456909256 ms

# 58.0.3024.0 (Official Build) canary (64-bit)
 avg 944.1679999999999 ms
 median 944.2900000000004 ms
 stdev 5.375929882845524 ms

BUG=474121
TEST=n/a; no behavior change
==========

to

==========
Convert layout test password-delete-performance.html to performance test

This patch converts layout test "password-delete-performance.html" to
performance test since the purpose of this test if measuring performance of
deleting character in password field.

Test results:
# 56.0.2924.87 (Official Build) (64-bit)
 avg 30.719000000000015 ms
 median 30.617500000000007 ms
 stdev 1.5581978456909256 ms

# 58.0.3024.0 (Official Build) canary (64-bit)
 avg 944.1679999999999 ms
 median 944.2900000000004 ms
 stdev 5.375929882845524 ms

BUG=474121
TEST=n/a; no behavior change

Review-Url: https://codereview.chromium.org/2730433004
Cr-Commit-Position: refs/heads/master@{#454818}
Committed:
https://chromium.googlesource.com/chromium/src/+/42bca36878d20e2bf6f27fb091d6...
==========

[commit-bot: I haz the power, 2017-03-06 03:39:22]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/42bca36878d20e2bf6f27fb091d6...

[yoichio, 2017-03-16 02:13:32]

On 2017/03/06 03:39:22, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/chromium/src/+/42bca36878d20e2bf6f27fb091d6...

I found you deleted password-delete-contents.html instead of
password-delete-performance.html.