Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2730323002: [deoptimizer] When deoptimizing code, unlink all functions referring to that code. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] When deoptimizing code, unlink all functions referring to that code. Drive by: remove two unused methods in optimized code visitor. Review-Url: https://codereview.chromium.org/2730323002 Cr-Commit-Position: refs/heads/master@{#43611} Committed: https://chromium.googlesource.com/v8/v8/+/fe704477d6b515f2ab2b13cb26eb05556a2cf134

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -27 lines) Patch
M src/debug/liveedit.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +22 lines, -5 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +3 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-unlink-closures-on-deopt.js View 1 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Jarin
Could you take a look, please? To be honest, I am not sure whether we ...
3 years, 9 months ago (2017-03-06 11:32:57 UTC) #8
Yang
src/debug/ lgtm.
3 years, 9 months ago (2017-03-06 11:51:16 UTC) #10
Benedikt Meurer
I don't link the mjsunit test, but... LGTM
3 years, 9 months ago (2017-03-06 12:19:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730323002/20001
3 years, 9 months ago (2017-03-06 12:19:28 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/fe704477d6b515f2ab2b13cb26eb05556a2cf134
3 years, 9 months ago (2017-03-06 12:22:14 UTC) #16
Michael Starzinger
3 years, 9 months ago (2017-03-06 12:37:13 UTC) #17
Message was sent while issue was closed.
LGTM.

Powered by Google App Engine
This is Rietveld 408576698