Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2730303002: Move Feature Policy test to Frame (Closed)

Created:
3 years, 9 months ago by iclelland
Modified:
3 years, 9 months ago
Reviewers:
haraken, jbroman
CC:
blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chasej+watch_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, gogerald+paymentswatch_chromium.org, iclelland+watch_chromuim.org, iclelland, kinuko+watch, lunalu1, mahmadi+paymentswatch_chromium.org, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, rwlbuis, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Feature Policy test to Frame The code that tests whether FP-controlled features is no longer needed by bindings code, and so shouldn't really live in Source/bindings. This moves it to a more sensible location. Review-Url: https://codereview.chromium.org/2730303002 Cr-Commit-Position: refs/heads/master@{#454955} Committed: https://chromium.googlesource.com/chromium/src/+/6a8d425faa0c5cec9e5648d8297329d65764247e

Patch Set 1 #

Patch Set 2 : Fix rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.h View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ConditionalFeaturesForCore.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
iclelland
+r jbroman -- can you PTAL? Thanks
3 years, 9 months ago (2017-03-06 17:00:50 UTC) #11
haraken
LGTM
3 years, 9 months ago (2017-03-06 18:41:35 UTC) #12
jbroman
lgtm
3 years, 9 months ago (2017-03-06 20:31:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730303002/20001
3 years, 9 months ago (2017-03-06 21:00:06 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 21:12:27 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6a8d425faa0c5cec9e5648d82973...

Powered by Google App Engine
This is Rietveld 408576698