Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2730293002: [profiler] This adds function butterflies to the function list. (Closed)

Created:
3 years, 9 months ago by Jarin
Modified:
3 years, 9 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] This adds function butterflies to the function list. The function list is now filtered by category by default, and sorting improved to break ties better. Since the butterfly trees get massive, I had to start expanding the call trees on demand. This is implemented by keeping track of all ticks that cross given tree node (+ position where they crosses it). This seems to work quite well - in subsequent CL, I am planning to flip the bottom-up and top-down trees to use this. Review-Url: https://codereview.chromium.org/2730293002 Cr-Commit-Position: refs/heads/master@{#43602} Committed: https://chromium.googlesource.com/v8/v8/+/437dece4d9f06d12d7a8e38ee07e820c07533f9c

Patch Set 1 #

Patch Set 2 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -48 lines) Patch
M tools/profview/profile-utils.js View 7 chunks +157 lines, -37 lines 0 comments Download
M tools/profview/profview.css View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/profview/profview.js View 1 6 chunks +26 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Jarin
Could you take a look, please?
3 years, 9 months ago (2017-03-05 21:33:55 UTC) #7
Camillo Bruni
lgtm
3 years, 9 months ago (2017-03-06 09:24:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730293002/20001
3 years, 9 months ago (2017-03-06 09:35:17 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 09:37:43 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/437dece4d9f06d12d7a8e38ee07e820c075...

Powered by Google App Engine
This is Rietveld 408576698