Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2730283002: Cleanups in the wake of various metrics refactorings. (Closed)

Created:
3 years, 9 months ago by grt (UTC plus 2)
Modified:
3 years, 9 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, asvitkine+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanups in the wake of various metrics refactorings. - IWYU fixes in chrome_stability_metrics_provider.cc following r351036 and r390161. - Removal of chrome_watcher's depency on //chrome/common:metrics_constants_util_win (introduced accidentally in r387669). - Removal of install_static::GetBrowserCrashDumpAttemptsRegistryPath (the need was removed in r390161, possibly while its addition was being reviewed). BUG=606448 R=asvitkine@chromium.org,siggi@chromium.org Review-Url: https://codereview.chromium.org/2730283002 Cr-Commit-Position: refs/heads/master@{#454997} Committed: https://chromium.googlesource.com/chromium/src/+/77e77eb0235255724e0688102a26e64fd4b4482b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M chrome/browser/metrics/chrome_stability_metrics_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/chrome_watcher/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/install_static/install_util.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/install_static/install_util.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
grt (UTC plus 2)
PTAL
3 years, 9 months ago (2017-03-05 21:10:28 UTC) #3
Sigurður Ásgeirsson
lgtm
3 years, 9 months ago (2017-03-06 14:22:50 UTC) #6
Alexei Svitkine (slow)
lgtm
3 years, 9 months ago (2017-03-06 22:04:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730283002/1
3 years, 9 months ago (2017-03-06 22:04:32 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 23:30:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/77e77eb0235255724e0688102a26...

Powered by Google App Engine
This is Rietveld 408576698