Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2730273002: Enable -Wblock-capture-autoreleasing (Closed)

Created:
3 years, 9 months ago by Nico
Modified:
3 years, 9 months ago
Reviewers:
sdefresne, justincohen
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang: Stop disabling -Wblock-capture-autoreleasing Things should build with it enabled now, and it's a useful warning. BUG=691120 Review-Url: https://codereview.chromium.org/2730273002 Cr-Commit-Position: refs/heads/master@{#454895} Committed: https://chromium.googlesource.com/chromium/src/+/0f16147c62ef8635f594ed77c415cc9de2ece5a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Nico
3 years, 9 months ago (2017-03-05 19:02:24 UTC) #2
Nico
Looks like Justin's out. sdefresne, wanna stamp? If so, please also hit cq.
3 years, 9 months ago (2017-03-06 03:34:18 UTC) #8
sdefresne
lgtm
3 years, 9 months ago (2017-03-06 18:10:28 UTC) #9
sdefresne
Looks like the downstream bots are happy with this CL, so I think it is ...
3 years, 9 months ago (2017-03-06 18:10:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730273002/1
3 years, 9 months ago (2017-03-06 18:20:51 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:30:16 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f16147c62ef8635f594ed77c415...

Powered by Google App Engine
This is Rietveld 408576698