Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2730203002: Revert of Discard compositor frames from unloaded web content (Closed)

Created:
3 years, 9 months ago by sclittle
Modified:
3 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, site-isolation-reviews_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Discard compositor frames from unloaded web content (patchset #11 id:200001 of https://codereview.chromium.org/2707243005/ ) Reason for revert: It looks like this broke the MSAN bot: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20MSAN/builds/731 Original issue's description: > Discard compositor frames from unloaded web content > > After a navigation commits, it is still possible for the compositor to > resend a frame that draws the previous (now unloaded) page. In some > situations this works against the browser process' new content > rendering timer that attempts to clear a page after 4 seconds if a > navigation has committed but not yet painted in that time. > > This CL adds a counter called content_source_id to that increments on > every non-same-page navigation commit under a given top-level > RenderWidget. It tags the CompositorFrameMetadata with this identifier, > and also sends it to the browser process with the > DidCommitProvisionaLoad IPC message. This enables the browser to > recognize compositor frames with stale IDs, corresponding to unloaded > pages. > > BUG=672847 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation > > Review-Url: https://codereview.chromium.org/2707243005 > Cr-Commit-Position: refs/heads/master@{#454578} > Committed: https://chromium.googlesource.com/chromium/src/+/efd1189a0b3febada2bceb4c037fff1718306a3a TBR=enne@chromium.org,creis@chromium.org,danakj@chromium.org,kenrb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672847 Review-Url: https://codereview.chromium.org/2730203002 Cr-Commit-Position: refs/heads/master@{#454732} Committed: https://chromium.googlesource.com/chromium/src/+/cee456faba216e014f2ce2ded37e2cde5fc19cfd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -169 lines) Patch
M cc/ipc/cc_param_traits_macros.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/compositor_frame_metadata.mojom View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/compositor_frame_metadata_struct_traits.h View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/ipc/compositor_frame_metadata_struct_traits.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/ipc/struct_traits_unittest.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/output/compositor_frame_metadata.h View 1 chunk +0 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 3 chunks +0 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 2 chunks +2 lines, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 3 chunks +3 lines, -36 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/render_widget.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
sclittle
Created Revert of Discard compositor frames from unloaded web content
3 years, 9 months ago (2017-03-04 00:54:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730203002/1
3 years, 9 months ago (2017-03-04 00:55:01 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 00:57:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cee456faba216e014f2ce2ded37e...

Powered by Google App Engine
This is Rietveld 408576698