Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2730183002: Fix composited toolbar in incorrect position for Chrome Home (Closed)

Created:
3 years, 9 months ago by mdjones
Modified:
3 years, 9 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix composited toolbar in incorrect position for Chrome Home Previously resize events did not explicitly trigger renders from the compositor. This went unnoticed because most of the UI existed at the top of the screen which was largely unaffected by the resize event. Now, the ToolbarSceneLayer is responsible for requesting renders when it is at the bottom of the screen. BUG=698111 Review-Url: https://codereview.chromium.org/2730183002 Cr-Commit-Position: refs/heads/master@{#455781} Committed: https://chromium.googlesource.com/chromium/src/+/0df0c5fffb5b95da4cb59bdededb180367dc5e50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mdjones
ptal
3 years, 9 months ago (2017-03-04 00:17:33 UTC) #2
David Trainor- moved to gerrit
lgtm
3 years, 9 months ago (2017-03-09 16:42:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2730183002/1
3 years, 9 months ago (2017-03-09 16:56:37 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 17:36:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0df0c5fffb5b95da4cb59bdededb...

Powered by Google App Engine
This is Rietveld 408576698