Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: content/renderer/presentation/presentation_connection_proxy.cc

Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/presentation/presentation_connection_proxy.cc
diff --git a/content/renderer/presentation/presentation_connection_proxy.cc b/content/renderer/presentation/presentation_connection_proxy.cc
index aebff14183ac5a7de998df1213d7c7f8da41c179..6378d3da66b4bdba382511774cf7bf20da8d1ede 100644
--- a/content/renderer/presentation/presentation_connection_proxy.cc
+++ b/content/renderer/presentation/presentation_connection_proxy.cc
@@ -67,8 +67,8 @@ void PresentationConnectionProxy::DidChangeState(
source_connection_->didChangeState(
blink::WebPresentationConnectionState::Connected);
} else if (state == content::PRESENTATION_CONNECTION_STATE_CLOSED) {
- source_connection_->didChangeState(
- blink::WebPresentationConnectionState::Closed);
+ source_connection_->didClose(
+ blink::WebPresentationConnectionCloseReason::Closed, "");
} else {
NOTREACHED();
}
@@ -76,8 +76,8 @@ void PresentationConnectionProxy::DidChangeState(
void PresentationConnectionProxy::OnClose() {
DCHECK(target_connection_ptr_);
- source_connection_->didChangeState(
- blink::WebPresentationConnectionState::Closed);
+ source_connection_->didClose(
+ blink::WebPresentationConnectionCloseReason::Closed, "");
target_connection_ptr_->DidChangeState(
mark a. foltz 2017/03/06 18:57:55 Part of the connection refactoring should better a
zhaobin 2017/03/06 19:52:23 Acknowledged.
content::PRESENTATION_CONNECTION_STATE_CLOSED);
}

Powered by Google App Engine
This is Rietveld 408576698