content/renderer/presentation/presentation_connection_proxy_unittest.cc - Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/presentation/presentation_connection_proxy_unittest.cc

Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/presentation/presentation_connection_proxy.cc ('K') | « content/renderer/presentation/presentation_connection_proxy.cc ('k') | content/renderer/presentation/test_presentation_connection.h » ('j') | third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/presentation/presentation_connection_proxy_unittest.cc

diff --git a/content/renderer/presentation/presentation_connection_proxy_unittest.cc b/content/renderer/presentation/presentation_connection_proxy_unittest.cc

index 159becffc3604a9f34c798b79e0ddbf132caca14..3d78637a3a0f7d06c185a4c22537fa8e3d16bc60 100644

--- a/content/renderer/presentation/presentation_connection_proxy_unittest.cc

+++ b/content/renderer/presentation/presentation_connection_proxy_unittest.cc

@@ -115,9 +115,11 @@ TEST_F(PresentationConnectionProxyTest, TestSendArrayBuffer) {

TEST_F(PresentationConnectionProxyTest, TestControllerConnectionCallsClose) {

base::RunLoop run_loop;

EXPECT_CALL(*controller_connection_,

- didChangeState(blink::WebPresentationConnectionState::Closed));

+ didClose(blink::WebPresentationConnectionCloseReason::Closed,

+ blink::WebString("")));

EXPECT_CALL(*receiver_connection_,

- didChangeState(blink::WebPresentationConnectionState::Closed));

+ didClose(blink::WebPresentationConnectionCloseReason::Closed,

+ blink::WebString("")));

controller_connection_proxy_->close();

run_loop.RunUntilIdle();

}

@@ -125,9 +127,11 @@ TEST_F(PresentationConnectionProxyTest, TestControllerConnectionCallsClose) {

TEST_F(PresentationConnectionProxyTest, TestReceiverConnectionCallsClose) {

base::RunLoop run_loop;

EXPECT_CALL(*controller_connection_,

- didChangeState(blink::WebPresentationConnectionState::Closed));

+ didClose(blink::WebPresentationConnectionCloseReason::Closed,

+ blink::WebString("")));

EXPECT_CALL(*receiver_connection_,

- didChangeState(blink::WebPresentationConnectionState::Closed));

+ didClose(blink::WebPresentationConnectionCloseReason::Closed,

+ blink::WebString("")));

receiver_connection_proxy_->close();

run_loop.RunUntilIdle();

}