Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 27301003: Fixed bug in extractps instruction on ia32 and x64 (Closed)

Created:
7 years, 2 months ago by Sven Panne
Modified:
7 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Fixed bug in extractps instruction on ia32 and x64 This is a fixed version of https://codereview.chromium.org/27097002/ which was originally written by weiliang.lin@intel.com. R=bmeurer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -63 lines) Patch
M src/ia32/assembler-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +6 lines, -1 line 0 comments Download
M src/ia32/disasm-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x64/disasm-x64.cc View 11 chunks +19 lines, -19 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M test/cctest/test-assembler-x64.cc View 7 chunks +39 lines, -36 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
7 years, 2 months ago (2013-10-15 12:41:26 UTC) #1
Benedikt Meurer
LGTM
7 years, 2 months ago (2013-10-15 12:50:36 UTC) #2
Sven Panne
7 years, 2 months ago (2013-10-15 12:52:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17217 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698