Issue 273001: Remove the preference localizer class....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273001: Remove the preference localizer class.... (Closed)

Created:
11 years, 2 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the preference localizer class. Add some new strings that didn't exit to the grd file needed by Mac prefs. Update all the strings in the file to use the localizer. BUG=20538 TEST=Almost all the pref strings should be localized, there area few new ones that won't show up localized until we do a TC run. The controls do *NOT* auto size yet, so there can be clipping/oversized controls. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28539

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+181 lines, -176 lines)			Patch
M	chrome/app/generated_resources.grd	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/app/nibs/Preferences.xib	View	1	88 chunks	+170 lines, -128 lines	0 comments	Download
D	chrome/browser/cocoa/preferences_localizer.h	View	1	1 chunk	+0 lines, -18 lines	0 comments	Download
D	chrome/browser/cocoa/preferences_localizer.mm	View	1	1 chunk	+0 lines, -28 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 2 months ago (2009-10-09 15:48:44 UTC) #2

LGTM

http://codereview.chromium.org/273001/diff/1/2
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/273001/diff/1/2#newcode3999
Line 3999: <!-- Mac has a Toolbar group (IDS_OPTIONS_HOMEPAGE_SHOW_BUTTON move
in that) -->
Improve this comment to make sense.

http://codereview.chromium.org/273001/diff/1/2#newcode4003
Line 4003: <message name="IDS_OPTIONS_PAGE_OPTION_SHOW_BUTTON" desc="The label
of the 'Show home button on toolbar' checkbox">
The description isn't right.

Expand Messages | Collapse Messages